Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

use electron-prebuilt@^0.36.4, node >= 4 #153

Merged
merged 3 commits into from
Jan 21, 2016
Merged

use electron-prebuilt@^0.36.4, node >= 4 #153

merged 3 commits into from
Jan 21, 2016

Conversation

ungoldman
Copy link
Member

Hi friends!

I encountered a show-stopping error when running npm start with newer node (>= 4). Saw this in electron JS console.

Uncaught Error: Module version mismatch. Expected 46, got 47.

Using latest electron-prebuilt and node >= 4 seemed to take care of the issue.

I bumped electron-prebuilt to latest and set engines in package.json to:

"engines": {
  "node": ">=4",
  "npm": ">=2.8.3"
}

Adjusted docs to reflect the change and ran fixpack for good measure.

Getting things in order to take a crack at another sprint for #151.

@moose-team/owners please take a look and let me know if it's alright to forge ahead.

@ungoldman
use electron-prebuilt@^0.36.4, node >= 4
3f22ec8 
adjust docs to reflect change, run fixpack for good measure
@ungoldman
use loadURL (loadUrl is deprecated)
08ba048
@ungoldman ungoldman changed the title Bump use electron-prebuilt@^0.36.4, node >= 4 Jan 20, 2016
@max-mapper
Copy link
Member

+1

@beaugunderson
Copy link
Member

i see --target=0.34.2 in rebuild-leveld, that should be updated too yes?

@max-mapper
Copy link
Member

oh yea it should. we should automate that....

On Wed, Jan 20, 2016 at 12:55 PM, Beau Gunderson [email protected]
wrote:

i see --target=0.34.2 in rebuild-leveld, that should be updated too yes?

—
Reply to this email directly or view it on GitHub
#153 (comment).

@ungoldman
Copy link
Member Author

Good catch @beaugunderson, I'll add that to this PR

@ungoldman
Copy link
Member Author

Last commit takes electron version from package.json for both rebuild-leveldb script and electron-packager (pkg.js) script. @beaugunderson @maxogden let me know if that looks alright to you.

Was thinking of integrating https://github.com/moose-team/friends/pull/140/files#diff-fd4c3053b5f27a8826f2c5c106cb6adfR32 and https://github.com/moose-team/friends/pull/140/files#diff-fd4c3053b5f27a8826f2c5c106cb6adfR37 into this too to close #140.

@feross
Copy link
Member

feross commented Jan 21, 2016

Nice, LGTM!

@max-mapper
Copy link
Member

nice work @ngoldman

@beaugunderson
Copy link
Member

👍

ungoldman added a commit that referenced this pull request Jan 21, 2016
@ungoldman
Merge pull request #153 from moose-team/bump
2a02581 
use electron-prebuilt@^0.36.4, node >= 4
@ungoldman ungoldman merged commit 2a02581 into master Jan 21, 2016
@ungoldman ungoldman deleted the bump branch January 21, 2016 18:15
@ungoldman ungoldman mentioned this pull request Jan 25, 2016
Closed
@ungoldman
Copy link
Member Author

Looks like windows is having trouble with $(../../version.js) (#154) -- should I revert this PR for now?

@lmatteis
Copy link

Shouldn't this fix it? https://github.com/atom/electron/blob/master/docs/tutorial/using-native-node-modules.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ungoldman @max-mapper @beaugunderson @feross @lmatteis